Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added type checking to params on model #676

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Added type checking to params on model #676

merged 7 commits into from
Sep 5, 2024

Conversation

juliaputko
Copy link
Contributor

No description provided.

@juliaputko juliaputko requested a review from ashao August 26, 2024 22:33
ashao
ashao requested changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. Some suggestions to generalize the check and to split up the tests.

@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (d7d979e) to head (c4a9991).
Report is 16 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #676      +/-   ##
===========================================
- Coverage    83.91%   81.84%   -2.08%     
===========================================
  Files           83       83              
  Lines         6284     7065     +781     
===========================================
+ Hits          5273     5782     +509     
- Misses        1011     1283     +272
Files with missing lines Coverage Δ
smartsim/entity/model.py 96.59% <100.00%> (+0.51%) ⬆️

... and 47 files with indirect coverage changes

ashao
ashao approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for covering this! Minor changes to make the changelog more descriptive, otherwise it's good to go

@juliaputko juliaputko merged commit 72be515 into CrayLabs:develop Sep 5, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashao ashao ashao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliaputko @ashao